Author Topic: send_* runs into infinite loop on too large blobs (Read 3886 times)

Alreadythere · « **on:** December 03, 2005, 11:25:18 pm »

When the blobsize gets too large on sending something, bebot produces infinite loops for me - till the bot crashs.

Looks like this then:

Always happens when bebot thinks it needs at least 3 pages.
I think the error is in the cut_size() function in Bot.php - but haven't gotten around to check more exactly yet.

Wolfbiter · « **Reply #1 on:** December 04, 2005, 06:32:01 am »

You're probably using <br> in the blob. You need to modify the cut_size function in bot.php

Code: [Select]

function cut_size($msg, $type, $to="", $pri=0)
    {
     preg_match("/^(.*)<a href=\"(.+)\">(.*)$/isU", $msg, $info);
     $info[2] = str_replace("<br>","\n",$info[2]);
     $content = explode("\n", $info[2]);
.... (original code past this point)

Alreadythere · « **Reply #2 on:** December 04, 2005, 01:51:40 pm »

Thanks, worked like a charm.

Khalem · « **Reply #3 on:** December 04, 2005, 06:14:54 pm »

Comitted to SVN. Thanx.

Hotshot · « **Reply #4 on:** September 09, 2006, 02:15:30 pm »

Im having trouble seeing where to put this fix, i see the "cut_size" text in the bot.php but im not sure where i put this fix,
"{
         $this -> cut_size($msg, "tell", $to, $low);
         $send = false;
      }"

thats whats in there at the moment, do i replace it with the new coding or what?

Also how do i get it to work on Guildbot?

Khalem · « **Reply #5 on:** September 09, 2006, 08:11:51 pm »

This fix has been in the bot for almost a year soon, so unless you are running a really really really old version of the bot, it's already in there.

An additional bug in Bot Help was fixed fairly recently.

Regardless, the function cut_size is still in Bot.php, you are just looking at one location where the function is called, not the actual function.

Hotshot · « **Reply #6 on:** September 10, 2006, 03:30:59 pm »

how come !memberlist doesnt work?

Khalem · « **Reply #7 on:** September 21, 2006, 04:59:52 pm »

Memberlist is not a part of the core bot, so i can't say.

JJ just pointed out that the fix has somehow managed to be omitted from the 0.2 branch. My apologies for the major oversight.