Author Topic: relaying commands between org/guest chat (Read 2013 times)

healnjoo · « **on:** November 15, 2007, 02:33:40 am »

running version .4.2 as an orgbot

Text between org/priv(guest) channels are relayed just fine, but any command such as !whois, !online etc is not relayed.

For example a !whois in org chat will do what is expected and display the whois information, but nothing is seen in guest chat. The reverse is also true if !whois is used in guest nothing is seen in org chat. You wont even see that the !whois command was issued from the channel that it wasn't initiated on.

So my question is: Is this normal behavior or did i bork something when playing with the config?

Temar · « **Reply #1 on:** November 15, 2007, 04:42:48 am »

this is normal

Vhab · « **Reply #2 on:** November 15, 2007, 12:11:26 pm »

it's intended as the alternative is prone to infinite loops and dodgy implementations.

healnjoo · « **Reply #3 on:** November 15, 2007, 09:00:38 pm »

bleh well bummer!

could you explain what the alternative is and how/why it would be prone to infinite loops and dodgy implementations.

any thing i code could be considered a dodgy implementation so i'm okay with that

thanks for the replies.

Alreadythere · « **Reply #4 on:** November 15, 2007, 11:33:20 pm »

Right now the relay module takes any line of normal chat that is not created by the bot nor by bots in the otherbots array and sends it over the relay. In addition to this modules can relay chat directly using a function in the relay module, but they have to implement this. One example that does this is the IRC module to relay any incoming IRC text if wished.

Relaying bot output in addition would either create spam loops as the bots would always parse it's own output and send it over the relay, including output of the relay module, or it would require some thorough parsing on every chatline running to detect what should and what shouldn't be relayed of the bot output. This would use a lot of computational time on any line of code that is avoided in the current way. Neither is advisable.

Temar · « **Reply #5 on:** November 16, 2007, 01:44:54 am »

if you realy wana see all the stuff like command and bot responce , do what i have done and have 2 bots on org channel

Tichy · « **Reply #6 on:** November 16, 2007, 02:48:57 am »

Command relaying is an interesting function. i.e. I would like to see guests and members in relayed orgs to see !items requests from the org channel to be able to follow discussions about weapons etc. The implementation seems simple to me if the core is modified this way:

- relay bot commands into all relayed channels
- change the send_gc/send_... functions to send to relayed channels (or create hooks for registering channels to get a common interface)

The relay module itself ignores any output of the bot itself and if the bots in relayed channels are configured correctly (the relaying bot is added to $other_bots in the config file), no looping or spamming should occur.

But relaying all commands might be little bit dangerous when leaking informations out of the org channel I guess.