General > Feedback and Suggestions

serious issue in MassMsg module !

(1/1)

bitnykk:
I discovered and fixed a serious issue that was resulting in huge spams (double message + 10 or more Preflinks) while using !massinv and !announce ...

The issue came from this part of code (line 148 to 153) :

--- Quote ---            $dis = $dis.$blobs[(int)$massmsg][(int)$massinv];
         }
         else
            $dis = "";

         $message = str_ireplace("##disable##", $dis, $msg);
--- End quote ---

With more than one recipient, the $dis variable would be filled of several times of itself. The fix i made was to use a different var :

--- Quote ---            $addlink = $dis.$blobs[(int)$massmsg][(int)$massinv];
         }
         else
            $addlink = "";

         $message = str_ireplace("##disable##", $addlink, $msg);
--- End quote ---

Khalem:
This was already fixed in trunk, but not backported to 0.6

Thanks for the heads up.

bitnykk:
Yaz, that was in the 0.6.8 i took @ launchpad.net from left menu upleft of page here.

Happy to know it's gonna be fixed :)

Navigation

[0] Message Index