BeBot - An Anarchy Online and Age Of Conan chat automaton

General => Feedback and Suggestions => Topic started by: bitnykk on November 13, 2010, 07:56:09 pm

Title: serious issue in MassMsg module !
Post by: bitnykk on November 13, 2010, 07:56:09 pm: I discovered and fixed a serious issue that was resulting in huge spams (double message + 10 or more Preflinks) while using !massinv and !announce ...

The issue came from this part of code (line 148 to 153) :
Quote
            $dis = $dis.$blobs[(int)$massmsg][(int)$massinv];
         }
         else
            $dis = "";

         $message = str_ireplace("##disable##", $dis, $msg);

With more than one recipient, the $dis variable would be filled of several times of itself. The fix i made was to use a different var :
Quote
            $addlink = $dis.$blobs[(int)$massmsg][(int)$massinv];
         }
         else
            $addlink = "";

         $message = str_ireplace("##disable##", $addlink, $msg);
Title: Re: serious issue in MassMsg module !
Post by: Khalem on November 15, 2010, 04:49:22 pm: This was already fixed in trunk, but not backported to 0.6

Thanks for the heads up.
Title: Re: serious issue in MassMsg module !
Post by: bitnykk on November 16, 2010, 04:06:55 am: Yaz, that was in the 0.6.8 i took @ launchpad.net from left menu upleft of page here.

Happy to know it's gonna be fixed :)