collapse collapse
* User Info
 
 
Welcome, Guest. Please login or register.
* Search

* Board Stats
  • stats Total Members: 989
  • stats Total Posts: 18363
  • stats Total Topics: 2500
  • stats Total Categories: 7
  • stats Total Boards: 35
  • stats Most Online: 1144

Author Topic: Redundant code in roster.php  (Read 1783 times)

0 Members and 1 Guest are viewing this topic.

Offline MajorOutage

  • BeBot Rookie
  • *
  • Posts: 3
  • Karma: +0/-0
Redundant code in roster.php
« on: March 29, 2007, 11:12:22 am »
Whenever you add a member or guest without using the 'add' command, you get both a success msg and an error msg. Also, if you put a command but not a name, you get 2 error messages.

This is caused by lines 102-105 (for member) and 151-154 (for guest) in Modules/Roster.php
Code: [Select]
if (empty($vars[2]))
{
$this -> bot -> send_output($source, "You have to provide a character name", $type);
}

This is redundant code, as there are already error handlers in place for each command, and should be removed.

Offline Alreadythere

  • BeBot Maintainer
  • BeBot Hero
  • ******
  • Posts: 1288
  • Karma: +0/-0
Re: Redundant code in roster.php
« Reply #1 on: March 30, 2007, 12:17:35 am »
Not sure if it's redundant or a true bug.

That part of the code is supposed to handle !guest|member [add] name commands, which means the username could be in vars[1] or vars[2].

Offline Khalem

  • BeBot Founder
  • Administrator
  • ********
  • Posts: 1169
  • Karma: +0/-0
    • http://www.ancarim.com
Re: Redundant code in roster.php
« Reply #2 on: April 07, 2007, 03:28:16 am »
This is a bug.

Upon the first error you should bail.
BeBot Founder and Fixer Kingpin

 

* Recent Posts
[AoC] special char for items module by bitnykk
[February 09, 2024, 09:41:18 pm]


0.8.x updates for AoC by bitnykk
[January 30, 2024, 11:16:08 pm]


0.8.x updates for AO by bitnykk
[January 30, 2024, 11:15:37 pm]


BeBot still alive & kicking ! by bitnykk
[December 17, 2023, 12:58:44 am]


Bebot and Rasberry by bitnykk
[November 29, 2023, 11:04:14 pm]

* Who's Online
  • Dot Guests: 803
  • Dot Hidden: 0
  • Dot Users: 0

There aren't any users online.
* Forum Staff
bitnykk admin bitnykk
Administrator
Khalem admin Khalem
Administrator
WeZoN gmod WeZoN
Global Moderator
SimplePortal 2.3.7 © 2008-2024, SimplePortal