Author Topic: Whois.php doesn't work correctly (Read 1899 times)

CGamer · « **on:** May 09, 2008, 03:56:42 pm »

I found out that the links in the command !whois doesn't work because of these lines:

Quote

         $window .= $this -> bot -> core("tools") -> chatcmd('start ' . $funcomURL, 'Official character bio') . "\n";
         $window .= $this -> bot -> core("tools") -> chatcmd('start ' . $vhabotURL, 'Vhab\'s character info (beta)') . "\n";
         $window .= $this -> bot -> core("tools") -> chatcmd('start ' . $aunoURL, 'Auno\'s character info') . "\n";
      }

so i changed them(i found out how chatcmd() works in core/14_Tools.php) to this:

Quote

         $window .= $this -> bot -> core("tools") -> chatcmd($funcomURL, 'Official character bio', 'start') . "\n";
         $window .= $this -> bot -> core("tools") -> chatcmd($vhabotURL, 'Vhab\'s character info (beta)', 'start') . "\n";
         $window .= $this -> bot -> core("tools") -> chatcmd($aunoURL, 'Auno\'s character info', 'start') . "\n";

and it worked. I dont know if this Thread is in the correct category.

If i did anything wrong, say it to me.

[Note]
Sry for my english, I'm german and its very hard to write and speak english. I'm going to search for more wrong used chatcmd's. Maybe i've already found more of this wrong code.

[Edit]
Ok now i know that this is in the wrong category. It should be in "Coding and development discussion"

Alreadythere · « **Reply #1 on:** May 09, 2008, 04:23:04 pm »

0.5 forums is the correct one

Thanks for noticing us, those links are fixed in the SVN now.

Will make 0.5.1, which I'll try to publish beginning of next week to keep the momentum up.

CGamer · « **Reply #2 on:** May 09, 2008, 04:32:50 pm »

I just found out some more coding-errors:
complete fixed Links:

Quote

      if ($this -> bot -> core("settings") -> get("Whois", "ShowOptions") == TRUE)
      {
         $window .= "\n##normal##::: Options :::##end##\n";
         $window .= $this -> bot -> core("tools") -> chatcmd($whois['nickname'], 'Add to buddylist', 'cc addbuddy') . "\n";
         $window .= $this -> bot -> core("tools") -> chatcmd($whois['nickname'], 'Remove from buddylist', 'cc rembuddy') . "\n";
         $window .= $this -> bot -> core("tools") -> chatcmd('history ' . $whois['nickname'], 'Character history') . "\n";
      }

      if ($this -> bot -> core("settings") -> get("Whois", "ShowLinks") == TRUE)
      {
         $funcomURL = "http://people.anarchy-online.com/character/bio/d/" . $this -> bot -> dimension . "/name/" . strtolower($whois['nickname']);
         $vhabotURL = "http://characters.vhabot.net/character.php?character=" . strtolower($whois['nickname']) . "&dimension=" . $this -> bot -> dimension;
         $aunoURL = "http://auno.org/ao/char.php?dimension=" . $this -> bot -> dimension . "&name=" . strtolower($whois['nickname']);

         $window .= "\n##normal##::: Links :::##end##\n";
         $window .= $this -> bot -> core("tools") -> chatcmd($funcomURL, 'Official character bio', 'start') . "\n";
         $window .= $this -> bot -> core("tools") -> chatcmd($vhabotURL, 'Vhab\'s character info (beta)', 'start') . "\n";
         $window .= $this -> bot -> core("tools") -> chatcmd($aunoURL, 'Auno\'s character info', 'start') . "\n";
      }

      return ($this -> bot -> core("tools") -> make_blob("Details", $window));
   }

}
?>

ive added some case "...": to 14_Tools.php:

Quote

      switch($origin)
      {
         case'gc':
         case'o':
         case 3:
            $chatcmd = "o";
            Break;
         case'pgmsg':
         case'pg':
         case 2:
            $chatcmd = "group ".$this -> bot -> botname;
            Break;
         case 'start':
            $chatcmd = "start";
            Break;
         case 'cc addbuddy':
            $chatcmd = "cc addbuddy";
            Break;
         case 'cc rembuddy':
            $chatcmd = "cc rembuddy";
            Break;
         Default:
            $chatcmd = "tell ".$this -> bot -> botname;
      }

May i start working as a Bug-Hunter in BeBot php-files? Just asking^^

Alreadythere · « **Reply #3 on:** May 09, 2008, 05:34:38 pm »

Sure, bug-hunter are always welcome. But if you do that you should use an up-to-date SVN version. We do fix and change stuff in the trunk version regulary - there is a fix for the link trouble in SVN already, we just haven't done another official dev release yet.

CGamer · « **Reply #4 on:** May 09, 2008, 08:09:30 pm »

i'll download the newest SVN.

Is that a bug, that !Say has no Settings? I remember that !Say had settings...

[Edit]
Which is the correct SVN? tags/0.5.0/ or trunk/ ?

Khalem · « **Reply #5 on:** May 09, 2008, 08:59:10 pm »

trunk is the active development code.
tags are tagged releases which provide a snapshot of the code at the time of release. As such tags/0.5.0 represents the same code as available for download.

Temar · « **Reply #6 on:** May 09, 2008, 10:32:30 pm »

Say now output based on were u are
if u are on GC & PG it sends it both
if u are only in 1 of them it only sends to 1
if you are not in iver it returns in a tell