Author Topic: online is spaming (Read 34349 times)

Nytridr · « **on:** April 29, 2007, 08:07:37 pm »

when people log on they are sent the !online like 15 to 20 times.. doing the shared database with the latest svn updates

Code: [Select]

dwbot1 [2007-04-29 18:00:33]    [TELL]  [OUT]   -> Trukhack: /tell dwbot1 !help
dwbot1 [2007-04-29 18:00:38]    [TELL]  [OUT]   -> Trukhack: 34 members online i
n Guild. 0 members in Privategroup. :: [link]click to view[/link]
dwbot1 [2007-04-29 18:00:38]    [TELL]  [OUT]   -> Trukhack: /tell dwbot1 !help
dwbot1 [2007-04-29 18:00:42]    [TELL]  [OUT]   -> Trukhack: 34 members online i
n Guild. 0 members in Privategroup. :: [link]click to view[/link]
dwbot1 [2007-04-29 18:00:42]    [TELL]  [OUT]   -> Trukhack: /tell dwbot1 !help
dwbot1 [2007-04-29 18:00:46]    [TELL]  [OUT]   -> Trukhack: 34 members online i
n Guild. 0 members in Privategroup. :: [link]click to view[/link]
dwbot1 [2007-04-29 18:00:46]    [TELL]  [OUT]   -> Trukhack: /tell dwbot1 !help
dwbot1 [2007-04-29 18:00:51]    [TELL]  [OUT]   -> Trukhack: 34 members online i
n Guild. 0 members in Privategroup. :: [link]click to view[/link]
dwbot1 [2007-04-29 18:00:51]    [TELL]  [OUT]   -> Trukhack: /tell dwbot1 !help
dwbot1 [2007-04-29 18:00:55]    [TELL]  [OUT]   -> Trukhack: 34 members online i
n Guild. 0 members in Privategroup. :: [link]click to view[/link]
dwbot1 [2007-04-29 18:00:56]    [TELL]  [OUT]   -> Trukhack: /tell dwbot1 !help
dwbot1 [2007-04-29 18:01:04]    [TELL]  [OUT]   -> Trukhack: 34 members online i
n Guild. 0 members in Privategroup. :: [link]click to view[/link]

Alreadythere · « **Reply #1 on:** April 29, 2007, 09:08:21 pm »

What exactly are you doing?

Nytridr · « **Reply #2 on:** April 29, 2007, 11:19:21 pm »

logging on..

Nytridr · « **Reply #3 on:** April 29, 2007, 11:58:43 pm »

I think I found it.. I had a custom IRC file inplace and with the new updates and such it was causing tons of errors even out of memory errors and loops and what not.. I seen it go from 11,000k ram usage to 22000k ram usage in just 10 mins.. once I put back in the standard irc file it fixed everything.. so I am thinking there is something in what I have changed that is causing all these problems.

nope still doing it.. so IDK what is going on..

Alreadythere · « **Reply #4 on:** May 01, 2007, 07:23:36 am »

Try renaming modules/LogonNotify_GUILD.php to modules/_LogonNotify_GUILD.php.

If the error is gone then I know at least where to look, didn't have time to check myself yet and won't manage before tomorrow.

Nytridr · « **Reply #5 on:** May 01, 2007, 04:01:54 pm »

here is another problem I am seeing also.. tried to send a massmsg to let everyone know to let me know if they get spammed again.. and it didnt work..

Code: [Select]

rsbot [2007-05-01 13:57:31]     [TELL]  [OUT]   -> Aofbot: Mass message beeing s
ent. Please stand by...

Warning: array_keys(): The first argument should be an array in C:\aobots\RS\rsb
ot\modules\MassMsg.php on line 118

could be because I already renamed that.. didnt check it before hand.. but will later..

okay not sure if it is still doing it since even before it seems like it would do it to some while others didnt get it.. seems kind of random who got it.. but so far I have logged 3 of my toons and have not been spammed with it..

Code: [Select]

rsbot [2007-05-01 14:04:36]     [BUDDY] [LOG]   Nytridra logged [on] (OWNER)
rsbot [2007-05-01 14:04:37]     [GROUP] [MSG]   [Rising Sun (AoF)] Rsbot: "Nytri
dra" (Lvl 164 / 9 (Mediocre) Agent Squad Commander) logged on :: [link]Metanyt's
 Alts[/link]
rsbot [2007-05-01 14:04:45]     [TELL]  [OUT]   -> Nytridra: 13 members online i
n Guild. 0 members in Privategroup. :: [link]click to view[/link]
rsbot [2007-05-01 14:04:45]     [TELL]  [OUT]   -> Nytridra: /tell rsbot !help

okay seen it again.. this time it was only 2 times instead of 20 times.. so its getting better..

Code: [Select]

rsbot [2007-05-01 14:14:22]     [BUDDY] [LOG]   Mysticnyts logged [on] (LEADER)
rsbot [2007-05-01 14:14:23]     [GROUP] [MSG]   [Rising Sun (AoF)] Rsbot: Heaven
ly "Mysticnyts" Angel (Lvl 181 / 11 (Able) Adventurer Squad Commander) logged on
 :: [link]Nytsangel's Alts[/link]  ::  You hit Heckler of Harmony for 8335 point
s of Backstab damage.
rsbot [2007-05-01 14:14:34]     [TELL]  [OUT]   -> Mysticnyts: 16 members online
 in Guild. 0 members in Privategroup. :: [link]click to view[/link]
rsbot [2007-05-01 14:14:34]     [TELL]  [OUT]   -> Mysticnyts: /tell rsbot !help

rsbot [2007-05-01 14:14:34]     [TELL]  [OUT]   -> Mysticnyts: 16 members online
 in Guild. 0 members in Privategroup. :: [link]click to view[/link]
rsbot [2007-05-01 14:14:34]     [TELL]  [OUT]   -> Mysticnyts: /tell rsbot !help

Nytridr · « **Reply #6 on:** May 01, 2007, 11:39:00 pm »

Okay that seems to of fixed it.. People still get the !online at logon.. but they are not getting spammed..

Alreadythere · « **Reply #7 on:** May 02, 2007, 09:51:01 am »

The online spam is created by modules/LogonNotify_GUILD.php.

What did you modify to remove the spamming? Something in the SVN files or something in a custom file?

Nytridr · « **Reply #8 on:** May 02, 2007, 07:54:06 pm »

the only thing i did was renamed modules/LogonNotify_GUILD.php to modules/_LogonNotify_GUILD.php which stopped the spamming, but i am still getting the online list at logon..i have everything orgional.. but i do run 4 org bots with a shared !online database.. not sure if that has anything to do with it..

Alreadythere · « **Reply #9 on:** May 02, 2007, 07:58:09 pm »

The only module spamming online should be LogonNotify_GUILD.php...

Will check when I find time.

And no, shared online DB shouldn't matter much, running it here too and I get no online spam.

Nytridr · « **Reply #10 on:** May 02, 2007, 11:11:50 pm »

k.. I will look through and see if I have any custom files still in place.. when I first started having problems I backed everything up and deleted everything except the conf folder.. or I thought.. I will double check to make sure..

Nytridr · « **Reply #11 on:** May 02, 2007, 11:37:51 pm »

I have looked and I do not see any reason why anything should be sent in a tell to anyone in what I have.. I have looked through every file that has anything with "connect" in it and nothing is sending a tell when people log on except for the file I renamed.. IDK.. I did look through the php error log and just from yesterday I have some errrors that may or may not help out..

Code: [Select]

[01-May-2007 07:57:31] PHP Warning:  array_keys(): The first argument should be an array in C:\aobots\RS\rsbot\modules\MassMsg.php on line 118
[01-May-2007 08:00:12] PHP Warning:  array_keys(): The first argument should be an array in C:\aobots\RS\rsbot\modules\MassMsg.php on line 118
[01-May-2007 08:25:11] PHP Warning:  Invalid argument supplied for foreach() in C:\aobots\RS\rsbot\modules\IRC.php on line 698
[01-May-2007 08:25:11] PHP Warning:  ksort() expects parameter 1 to be array, null given in C:\aobots\RS\rsbot\modules\IRC.php on line 700
[01-May-2007 08:25:11] PHP Warning:  Invalid argument supplied for foreach() in C:\aobots\RS\rsbot\modules\IRC.php on line 702
[01-May-2007 15:32:57] PHP Warning:  Invalid argument supplied for foreach() in C:\aobots\RS\rsbot\modules\IRC.php on line 698
[01-May-2007 15:32:57] PHP Warning:  ksort() expects parameter 1 to be array, null given in C:\aobots\RS\rsbot\modules\IRC.php on line 700
[01-May-2007 15:32:57] PHP Warning:  Invalid argument supplied for foreach() in C:\aobots\RS\rsbot\modules\IRC.php on line 702

I am just throwing everything in here maybe something will catch your eye.. I would like to get back to my custom IRC file but untill we get this figured out I am sticking with the default ones.. I will attach a text file with a list of all files I have and where.. maybe something I missed.. ..

okay here is a txt file with my bot directory ..
http://metanyt.homeip.net:8888/bebot/version_3/rsbot-dir.txt

Alreadythere · « **Reply #12 on:** May 03, 2007, 12:19:12 am »

You got two online files running, core/OnlineDB.php with module/OnlineDisplay.php for the table based version, and core/Online.php for the outdated array based version no longer in SVN.

About those errors - neither MassMsg.php nor IRC were adapted to the new online table, both were still trying to use the old arrays. As that array no longer exists you got those warnings.
I've edited both files to use the tables I think, at least the code compiles. As I'm not using IRC at all nor mass messeges I couldn't test it.

Nytridr · « **Reply #13 on:** May 03, 2007, 12:33:56 am »

Quote from: Alreadythere on May 03, 2007, 12:19:12 am

You got two online files running, core/OnlineDB.php with module/OnlineDisplay.php for the table based version, and core/Online.php for the outdated array based version no longer in SVN.

awesome.. had a feeling I missed something.. that took care of showing the online during log on..I also renamed the LogonNotify_GUILD.php and going to test to see if it still spams.. now that the core/online.php is gone..

okay with logonnotify_guild.php back in I get the !online 2x's...

Code: [Select]

[Rsbot]: 20 members online in Guild. 0 members in Privategroup. :: click to view
[Rsbot]: /tell rsbot !help
[Rsbot]: 20 members online in Guild. 0 members in Privategroup. :: click to view
[Rsbot]: /tell rsbot !help

I think this problem is somewhere else.. not in the logonnotify_guild.php.. I was having a problem in another thing I was trying to make which I have stoped because I couldnt get past the double postings of things.. I am woundering if something in bot.php isnt right...

http://bebot.link/index.php/topic,752.0.html

that was why I was trying to sent to org chat with out the bot processing them.. this could be the same problem..

Nytridr · « **Reply #14 on:** May 03, 2007, 01:07:13 am »

Quote from: Alreadythere on May 03, 2007, 12:19:12 am

About those errors - neither MassMsg.php nor IRC were adapted to the new online table, both were still trying to use the old arrays. As that array no longer exists you got those warnings.
I've edited both files to use the tables I think, at least the code compiles. As I'm not using IRC at all nor mass messeges I couldn't test it.

They work.. ty.. now if you could put in there a setting for RAW mode or normal mode.. where sending to IRC with out any conversions of items and everything else.... and also something like what I did here...

Code: [Select]

		$maxcharsallowed = 457;
		$maxcharsexceeded = ("Your message contained " . strlen($msg) . " Characters.  Max characters allowed: " . $maxcharsallowed);

		if (strlen($msg) <= $maxcharsallowed)  //checks to see if the max allowed IRC message has been reached and if so sends a msg back to guild chat saying so

that would stop long scripts and stuff like that from being messed up and being sent over to IRC.. but this should probably be somewhere else.. I can let ya see my custom IRC file if you would like.. it has all that in it.. and you could adapt it to the IRC in an offical way..

Author Topic: online is spaming (Read 34349 times)

Nytridr

online is spaming

Alreadythere

Re: online is spaming

Nytridr

Re: online is spaming

Nytridr

Re: online is spaming

Alreadythere

Re: online is spaming

Nytridr

Re: online is spaming

Nytridr

Re: online is spaming

Alreadythere

Re: online is spaming

Nytridr

Re: online is spaming

Alreadythere

Re: online is spaming

Nytridr

Re: online is spaming

Nytridr

Re: online is spaming

Alreadythere

Re: online is spaming

Nytridr

Re: online is spaming

Nytridr

Re: online is spaming