Author Topic: Some minor issues (Read 12534 times)

Organizer · « **on:** November 03, 2008, 11:12:24 am »

Running latest combined build as always...

1. There is no space between level and class in the logon spam message...

2. There is no space between level and class on whois return...

3. The deluser command is not removing the character from the Alts list in case its there, maybe this could be improved... should be easy enough to do a check.

Thanks guys!

Organizer · « **Reply #1 on:** November 03, 2008, 02:07:28 pm »

And to add another point;

It would be great if !deluser would actually delete the users fully and not just mark them as being deleted and keep them in the DB.

I'm not sure about the original logic behind how it works now, but at least for our guild its simply annoying . E.g. we're getting log-on/log-off spam and gratz messages for people who are no longer in the guild

Before I upgraded to latest build I had to program a proper actual delete myself, but if this be done or at least be an option in the source it would be much appreciated (including deleting the person then from any other relevant tables, most likely just the mentioned Alts table).

Thank you

Temar · « **Reply #2 on:** November 04, 2008, 07:56:27 am »

1. There is no space between level and class in the logon spam message...Fixed

2. There is no space between level and class on whois return...Fixed

3. The deluser command is not removing the character from the Alts list in case its there, maybe this could be improved... should be easy enough to do a check.I dont think Alts should be removed just because you removed from bot, alts are only alts even if the user leave org all together it jst means they mostly wont get used, some people may leave org/ get removed for other reason but the char is still there alt regardless and shouldnt be removed, i had added alts of people i know that arnt even in my org to the bot so it gets used for !is etc

It would be great if !deluser would actually delete the users fully and not just mark them as being deleted and keep them in the DB.I have Fixed it so Users are now removed from notify when deleted

Organizer · « **Reply #3 on:** November 04, 2008, 12:55:38 pm »

Thanks for fixing the bugs Temar. I presume we have different use of the bot when it comes to deletions and alts. For our guild bot we only add actual members of the guild and their alts. We also use this data for show guild stats, like pulling out the number actual guild members (mains only) and logically alts separately, alts/mains per class, level range of the characters main/alts and so on...

I know there would have been a way to check if chars have been deleted/banned or not when calculating those stats, but much due to the unwanted gratz/log-on/off spam we started early to simply clean it up manually and deleting their row in the DB, and I as well modified the delete function in 5.2. to check and remove the character from the Alts table and as well the Whois table... I guess I might choose that again but we'll see then

Another question:

When doing a whois there is something called :::: option :::: with the command Add to buddylist and Remove from buddylist. Both these have never ever worked on our bot, and I do not as well understand the proper intention/use for them. So why is this option there if its not working, or have I set something up wrong, maybe it can/should be removed. What is the idea behind this addbuddy thing?

Temar · « **Reply #4 on:** November 04, 2008, 07:45:44 pm »

those are simply option a user may use to add some 1 to there list after doing a whois, they are simple commands for the user to use, not bot related
howeva im not sure if AoC command to add a user to friends list is diferent than /cc addbuddy name

Organizer · « **Reply #5 on:** November 05, 2008, 09:19:24 am »

Ah, while the /cc addbuddy and delbuddy works the links in the whois has as I mentioned never ever worked. It simply produces a /tell <botname> !help as being an unknown command.

So the question would be if it's working, or it is something with our bot. Secondly if it's supposed to be there the name buddy is not really logic within AoC, so it needs to be fixed and in my eyes renames to Add to Friends List and Remove from Friends List. Do you have time to look into this one?

thanks!

Temar · « **Reply #6 on:** November 09, 2008, 09:55:57 pm »

the /cc buddy links in the !whois Details Blob Should now Work correctly

Fyorie · « **Reply #7 on:** March 08, 2009, 01:34:54 am »

Quote from: Organizer on November 05, 2008, 09:19:24 am

Ah, while the /cc addbuddy and delbuddy works the links in the whois has as I mentioned never ever worked. It simply produces a /tell <botname> !help as being an unknown command.

So the question would be if it's working, or it is something with our bot. Secondly if it's supposed to be there the name buddy is not really logic within AoC, so it needs to be fixed and in my eyes renames to Add to Friends List and Remove from Friends List. Do you have time to look into this one? thanks!

*tips glasses toward nose* Mmm yes. It would appear that we are having the same issue *pushes glasses up with fingertip*