Author Topic: Bug & Fix for Items.php Module: Can't submit items with Hyphens in the name (Read 1533 times)

durroch · « **on:** July 26, 2008, 07:45:20 am »

Greetings,

I noticed that the pref_match_all was not correctly picking up items with hyphens (or dashes "-") in their name and submitting them to the master database. To correct this problem goto modules/Items.php and on line 170, change it from:

Code: [Select]

if (preg_match_all("/(<a style=\"text-decoration:none\" href=\"itemref:\/\/([0-9]*)\/([0-9]*)\/([0-9]*)\/([0-9a-f]*\:[0-9a-f]*\:[0-9a-f]*:[0-9a-f]*)\/([0-9a-f]*\:[0-9a-f]*\:[0-9a-f]*:[0-9a-f]*)\"><font color=#([0-9a-f]*)>\[([a-zA-Z0-9_'&\s]*)\]<\/font><\/a>)/i",$msg,$matches,PREG_SET_ORDER))

to

Code: [Select]

if (preg_match_all("/(<a style=\"text-decoration:none\" href=\"itemref:\/\/([0-9]*)\/([0-9]*)\/([0-9]*)\/([0-9a-f]*\:[0-9a-f]*\:[0-9a-f]*:[0-9a-f]*)\/([0-9a-f]*\:[0-9a-f]*\:[0-9a-f]*:[0-9a-f]*)\"><font color=#([0-9a-f]*)>\[([\-a-zA-Z0-9_'&\s]*)\]<\/font><\/a>)/i",$msg,$matches,PREG_SET_ORDER))

Just adding two characters "\-" is all

. I did that, restarted the bot and showed it some items with "-" in it's name like "[Mocking Iron-ring Armguards]" and I got "Congratulations!! You are the world's first to discover [Mocking Iron-ring Armguards]!"