Author Topic: Read error: EOF on whois/Buddy-Add event (Read 11982 times)

Apollyon · « **Reply #30 on:** January 26, 2010, 04:41:51 am »

Guildbot [2010-01-26 03:35:09]	[BUDDY]	[LOG]	Alexander changed status [1] (MEMBER)
Guildbot [2010-01-26 03:35:09]	[BUDDY]	[BUDDY-ADD]	Quickstop(4294967295)
Debug: buddy_add called with final UID 4294967295 passed to server.
Read error: EOF
Read error: EOF
Read error: EOF
Read error: EOF
Read error: EOF
Read error: EOF
Guildbot [2010-01-26 03:35:09]	[BUDDY]	[BUDDY-ADD]	Rhaistlo(17309048)
Debug: buddy_add called with final UID 17309048 passed to server.
Guildbot [2010-01-26 03:35:09]	[BUDDY]	[LOG]	Alexander changed status [6] (MEMBER)
Read error: EOF

Believe Quickstop is an alt of Alexander. Quickstop was not in the users table or on the friends list.

Baldrick · « **Reply #31 on:** January 26, 2010, 08:04:04 pm »

Code: [Select]

Thespeaker [BUDDY]      [LOG]   Terhalis changed status [1] (ADMIN)                                                                                                                                              
Thespeaker [BUDDY]      [BUDDY-ADD]     Woeful(4294967295)                                                                                                                                                       
Debug: buddy_add called with final UID 4294967295 passed to server.                                                                                                                                              
Thespeaker [BUDDY]      [LOG]   Terhalis changed status [6] (ADMIN)                                                                                                                                              
Read error: EOF

Same error again...Woeful is not an alt of Terhalis.

Khalem · « **Reply #32 on:** January 28, 2010, 11:41:56 am »

This looks bad.

From the recent output there seems we have no way of telling if it is an invalid character or not.
Not sure how to attack this offhand.

Baldrick: Any chance you could send me a database dump from your bot? PM, Email or Dropbox etc?

Apollyon · « **Reply #33 on:** January 30, 2010, 08:27:16 pm »

Code: [Select]

Guildbot [2010-01-30 19:27:50]	[BUDDY]	[BUDDY-ADD]	Johnysins(4294967295)
Debug: buddy_add called with final UID 4294967295 passed to server.
Guildbot [2010-01-30 19:27:50]	[BUDDY]	[LOG]	Johnyhox changed status [6] (MEMBER)

Warning: socket_read(): unable to read from socket [104]: Connection reset by peer in /home/tiwaz/bebot/Sources/AOChat.php on line 305
Read error: Connection reset by peer

Need a copy of mine as well?

Esgs · « **Reply #34 on:** February 03, 2010, 08:05:28 pm »

This has been a problem for our bot for months. A whois on an invalid character name will trigger the bot crash. Adding an invalid character as an alt will get the bot to crash repeatedly until it's manually deleted from the users and alts tables.

My debug follows:

Taobot [2010-02-02 20:00:42] [TELL] [INC] Ganesa: !whois adfadfg
Taobot [2010-02-02 20:00:42] [BUDDY] [BUDDY-ADD] Adfadfg(4294967295)
Debug: buddy_add called with final UID 4294967295 passed to server.
Read error: EOF
Taobot [2010-02-02 20:00:42] [CONN] [ERROR] Bot has disconnected. Reconnecting in 60 seconds.

This is with the workaround attempt in place. Looks the same without.

Thank you for your attention to this matter!

Esgs · « **Reply #35 on:** February 03, 2010, 08:15:41 pm »

Fix as follows: Change main/15_AOChatWrapper.php

Code: [Select]

                        if (!($this -> bot -> aoc -> buddy_exists($uid)) && $uid != 0 && $uid != -1
                        && $uid != $this -> get_uid($this -> bot -> botname) && $this -> get_uname($uid) != -1)

to

Code: [Select]

                        if (!($this -> bot -> aoc -> buddy_exists($uid)) && $uid != 0 && $uid != -1
                        && $uid != 4294967295
                        && $uid != $this -> get_uid($this -> bot -> botname) && $this -> get_uname($uid) != -1)

Any reason not to do this? looks like whois still works fine for valid users.

Khalem · « **Reply #36 on:** February 03, 2010, 09:29:57 pm »

I was about to say that it would not work.

But you spotted what I had overlooked completely. The userid is in fact the same for all entries causing errors.
The userid (4294967295) is incidentally the highest 32bit integer allowed for an unsigned container.

I'll need to investigate a little further, but offhand that will be a good workaround.
A proper fix would likely be to ensure the bot does not overflow in the first place, but we need to redo the internal handling of userid's for that most likely.

Mahvo · « **Reply #37 on:** February 04, 2010, 03:15:24 pm »

I have had the same error for months - I disabled whole whois-module from bot so that people wouldn't (when drunk) wrote !whois <enter invalid mispelled name here> and crash the bot... But deleted alts, people who took server transfer etc always crashes the bot in buddy add, which gives me a lot of extra DB management duty.

I'll try the suggested fix here when next time booting up.

Mahvo · « **Reply #38 on:** February 04, 2010, 06:14:43 pm »

Ok, quick fixes here seem to work. The bot just ignores players that do not exist in alts, whois or is. Great! No more crashes from buddy add.

Runemy · « **Reply #39 on:** May 07, 2010, 04:20:29 am »

Been having a world of problems with this error tonight. I've tried the fix written above, but it doesn't seem to fix it

It came out of the blue after working perfectly for a long time.

But the bot starts up fine, logs in and everything, but after a short while it crashes after an eof error.

Runemy · « **Reply #40 on:** May 07, 2010, 01:26:55 pm »

Having had the same database for ages I decided to start a fresh one and only import the really large entries and it seems like it's working as intended now.