Author Topic: Buddy Queue on Startup (Read 5972 times)

SudL · « **Reply #15 on:** January 10, 2011, 11:37:01 pm »

test this:

"!buddylist clear"

wait 5 minutes than:

"!rosterupdate"

should be help.....

GBH · « **Reply #16 on:** January 12, 2011, 10:02:40 am »

"[BUDDY QUEUE] [BUDDY-ADD] -1"

This was first thing this morning.

It made absolutely no difference at all

G

Kentarii · « **Reply #17 on:** January 13, 2011, 03:33:26 am »

The dumb/obvious question would be:
Do you have any entries in you bot's _users table with nickname '-1'?

With that out of the way...
Which version are you running?

My guess is that this problem is tied to the workaround in AOChat.php
Line 388-402 (approx).

Code: [Select]

			case AOCP_CLIENT_LOOKUP :
				list($id, $name) = $packet->args;
				$id   = "" . $id;
				$name = ucfirst(strtolower($name));
				
				// *** FIXME ***
				// This is an ugly workaround for now to deal with overflowing 32bit int in Age of Conan
				if ($id == 4294967295)
				{
					$id = -1;
				}

				$this->id[$id]   = $name;
				$this->id[$name] = $id;
				break;

So.. the bot fails to find a valid id for a character and the workaround gives the character an id of -1.
So next time the bot looks for a character name, it returns id -1 and tries to add that during the rosterupdate.

But i'm kinda dumbfounded about that workaround actually.. why doesn't it modify the packet value as well, because 4294967295 will be passed back to the the function requesting the packet.

I modified my AOChat.php line 1205 (approx) to:

Code: [Select]

if($uid == -1 || $uid == 0 || $uid == 4294967295)Without the above modification, I got a lot of these lines:

Code: [Select]

[BUDDY] [BUDDY-ADD]     Received add request for (4294967295) This user is likely in the userlist and might need to be manually removed if this error persists.

GBH · « **Reply #18 on:** January 29, 2011, 08:04:10 pm »

Quote from: Kentarii on January 13, 2011, 03:33:26 am

The dumb/obvious question would be:
Do you have any entries in you bot's _users table with nickname '-1'?

With that out of the way...
Which version are you running?

My guess is that this problem is tied to the workaround in AOChat.php
Line 388-402 (approx).
Code: [Select]
case AOCP_CLIENT_LOOKUP : list($id, $name) = $packet->args; $id = "" . $id; $name = ucfirst(strtolower($name)); // *** FIXME *** // This is an ugly workaround for now to deal with overflowing 32bit int in Age of Conan if ($id == 4294967295) { $id = -1; } $this->id[$id] = $name; $this->id[$name] = $id; break;So.. the bot fails to find a valid id for a character and the workaround gives the character an id of -1.
So next time the bot looks for a character name, it returns id -1 and tries to add that during the rosterupdate.

But i'm kinda dumbfounded about that workaround actually.. why doesn't it modify the packet value as well, because 4294967295 will be passed back to the the function requesting the packet.

I modified my AOChat.php line 1205 (approx) to:
Code: [Select]
if($uid == -1 || $uid == 0 || $uid == 4294967295)Without the above modification, I got a lot of these lines:
Code: [Select]
[BUDDY] [BUDDY-ADD] Received add request for (4294967295) This user is likely in the userlist and might need to be manually removed if this error persists.

I get random "-1"'s in the user, whois and online tables and I manually remove them using a database editor. The whois is the one that gets the -1 most often. I think it then propagates to the other tables.

It's 0.6.7 but has happened all the way back to 0.6.4 I think. Quite a while anyway. I don't think it's particularly relevant but I can happily update if theres a chance it will sort the problem.

Cheers for looking at it.

G