Author Topic: Quotes! (Read 38579 times)

Ebag333 · « **Reply #15 on:** September 14, 2007, 04:41:10 pm »

Hmm, that DOES seem to be a rather silly way of handling that.

Blueeagle · « **Reply #16 on:** September 14, 2007, 04:42:27 pm »

The send_quote way of getting a random quote is horrible. Try this for a function send_quote instead:

	function send_quote($qnum)
	{ // Start function send_quote()
		$strquote = "";
		if($qnum == -1) 
		{
			// Get a random quote
			$sql = "SELECT * FROM #___quotes ORDER BY RAND() LIMIT 1";
			$result = $this -> bot -> db -> select($sql, MYSQL_ASSOC);
			if(!empty($result)) 
			{
				$strquote = "#" . $result[0]['id'] . " - " . $result[0]['quote'] . " [Contributed by: " . $result[0]['contributor'] . "]";
			}
			else 
			{
				$strquote = "No quotes exist. Add some!";
			}
		}
		else 
		{
    	//Get the quote with the given $qnum
			$sql = "SELECT * FROM #___quotes WHERE id=".$qnum;
			$result = $this -> bot -> db -> select($sql, MYSQL_ASSOC);
			if (!empty($result)) 
			{
				$strquote = "#" . $result[0]['id'] . " - " . $result[0]['quote'] . " [Contributed by: " . $result[0]['contributor'] . "]";
			} 
			else 
			{
				$strquote = "Quote with id of " . $qnum . " not found.";
			}         
		}
		return $strquote;
	} // End function send_quote()

Again I don't use this module so this code hasn't been tested.

Dracutza · « **Reply #17 on:** March 28, 2008, 03:48:43 am »

using temar's 0.4 -> 0.5 support/conversion file, i can get quotes to load, and display but on !quote add test, a new quote is not submitted and an old one is displayed.

On dropping the table, and letting the mod create a new one... !quote add test gets me:

Fatal error: Cannot use string offset as an array in P:\bots\custom\modules\Quotes.php on line 274

last line is 274

Code: [Select]

	// Get the ID of the highest quote. 
			$sql = "SELECT id FROM #___quotes ORDER BY id DESC LIMIT 1";
			$result = $this -> bot -> db -> select($sql);
			$num = intval($result[0][0]);

Temar · « **Reply #18 on:** March 28, 2008, 04:25:23 am »

the table is empty and there is no check
because its empty it isnt an array but the line is treating it as if it was

Dracutza · « **Reply #19 on:** March 28, 2008, 05:48:39 am »

ok but what about
bot: !quote add TEST TEST
bot: quote #33 blah blah

attempting to add a quote results in just another quote being displayed and nothing is submitted. as if the bot and the mod don't get past the whitespace after !quote.

Dracutza · « **Reply #20 on:** March 29, 2008, 06:12:29 pm »

applied blueeagle's suggestions

bot [2008-03-29 16:08:56] [TELL] [INC] Dracutza: !quote add test!
bot [2008-03-29 16:08:56] [TELL] [OUT] -> Dracutza: No quotes exist. Add some!

Blueeagle · « **Reply #21 on:** March 29, 2008, 11:18:09 pm »

This module is currently quite broken.

I have got a module for 0.5.x but it's not backwards compatible and unfortunately I do not see myself having time to backport it anytime soon.

Dracutza · « **Reply #22 on:** March 30, 2008, 08:18:22 am »

Quote from: Blueeagle on March 29, 2008, 11:18:09 pm

This module is currently quite broken.

I have got a module for 0.5.x but it's not backwards compatible and unfortunately I do not see myself having time to backport it anytime soon.

the one i have works just fine in 4... it's a 0.5 version I am looking for.

Blueeagle · « **Reply #23 on:** March 30, 2008, 08:42:42 am »

Quote from: Dracutza on March 30, 2008, 08:18:22 am

the one i have works just fine in 4... it's a 0.5 version I am looking for.

Oh. I juste assumed you wanted a 0.4-module since you're in the 0.4 module section of the forum..

The following does run on my bot, however I haven't tested it on a non-svn setup so it might not work out of the box.

Temar · « **Reply #24 on:** March 30, 2008, 09:13:14 am »

did u try running the 0.4 version on your 0.5 bot useing this module too

http://bebot.link/0-5-x-customunofficial-modules/0-4_support-for-latest-0-5/

Dracutza · « **Reply #25 on:** March 30, 2008, 05:48:40 pm »

Quote from: Temar on March 30, 2008, 09:13:14 am

did u try running the 0.4 version on your 0.5 bot useing this module too

http://bebot.link/0-5-x-customunofficial-modules/0-4_support-for-latest-0-5/

yes. it displays old ones, but will not accept additions

Dracutza · « **Reply #26 on:** March 30, 2008, 05:57:44 pm »

Quote from: Blueeagle on March 30, 2008, 08:42:42 am

The following does run on my bot, however I haven't tested it on a non-svn setup so it might not work out of the box.

doesn't for me.

it kills aorc when clicking the quote management interface

Quote

bot [2008-03-30 15:55:57] [TELL] [INC] Dracutza: quote add TEST TEST

bot [2008-03-30 15:55:57] [TELL] [OUT] -> Dracutza: Your quote has been added to the database
bot [2008-03-30 15:55:57] [TELL] [OUT] -> Dracutza: [link]Quote management interface[/link]
bot [2008-03-30 15:56:11] [PGRP] [MSG] [bot] Dracutza: !quote
bot [2008-03-30 15:56:11] [PGRP] [MSG] [bot] bot: Where were you
when Dracutza told me: ''?

funny... one version displays but does not accept, the other version accepts but does not display

Dracutza · « **Reply #27 on:** March 30, 2008, 07:00:18 pm »

Quote from: Dracutza on March 30, 2008, 05:57:44 pm

funny... one version displays but does not accept, the other version accepts but does not display

actually blueeagles 0.5 version does not really accept new ones either. In viewing the DB, it creates a record, and records the owner, but the quote is left blank.

Dracutza · « **Reply #28 on:** April 03, 2008, 05:38:04 pm »

any chance of getting Glara's Quote 100% 0.5 compatible?

Glarawyn · « **Reply #29 on:** April 03, 2008, 06:19:29 pm »

As a rule, I don't update my custom modules until we hit the release candidate stage of development.

If you want to pay me off in Supple bots or Combined Sharpshooter's armor or other in game loot that would be of interest I would be willing to shift game time to coding time.

Author Topic: Quotes! (Read 38579 times)

Ebag333

Re: Quotes!

Blueeagle

Re: Quotes!

Dracutza

Re: Quotes!

Temar

Re: Quotes!

Dracutza

Re: Quotes!

Dracutza

Re: Quotes!

Blueeagle

Re: Quotes!

Dracutza

Re: Quotes!

Blueeagle

Re: Quotes!

Temar

Re: Quotes!

Dracutza

Re: Quotes!

Dracutza

Re: Quotes!

Dracutza

Re: Quotes!

Dracutza

Re: Quotes!

Glarawyn

Re: Quotes!