Author Topic: Updated Quotes Module (Read 13646 times)

Glarawyn · « **Reply #15 on:** February 27, 2007, 09:14:07 pm »

Quote from: Malosar on February 27, 2007, 08:55:30 pm

You might get that in php5 if you don't have any quotes in your db. If you don't, add one then try.

Looking at the code, the only way you could get this message is if you tried to delete a quote when you had no quotes in the database.

Possible Fix: Replace Lines 206-210 with the following code:

Code: [Select]

} else {
         $res = $this -> bot -> db -> select("SELECT id FROM quotes ORDER BY id DESC");
         if (empty($res))
         {
             $out = " No quotes exisit in the database.";
         }
         else
         {
             $out = " (Highest quote ID is " . $res[0][0] . ".)";
         }
         $reply = "Quote with id of " . $qnum . " not found. (Highest quote ID is " . $out . ".)";
      }

Malosar · « **Reply #16 on:** February 27, 2007, 10:14:44 pm »

If he was using your original quotes module yes. But I assumed he was referring to JJ's updated version posted just before, which 210 refers to this section:

Code: [Select]

	function send_quote($qnum)
	{
		$strquote = "";
		if($qnum == -1)
		{
			$num = $this -> bot -> db -> select("SELECT id FROM quotes ORDER BY id DESC");
			$result = $this -> bot -> db -> select("SELECT * FROM quotes");
           
			if($num[0][0] > 0) <--- line 210

jjones666 · « **Reply #17 on:** February 27, 2007, 10:37:15 pm »

Yah, i'd suspect its due to auto spam being turned on by default and no quotes in db with php5.

-jj-

Ozball · « **Reply #18 on:** February 28, 2007, 03:13:53 am »

I'll try it again but i thought I'd turned autospam off (it was the first thing i thought might be a problem).

and yes it was the updated one from JJ

EDIT: Ok tested it seems to be that it is the no quotes in the DB problem. But tried useing !settings quotes auto off (using the page from !settings quotes) to turn off the spam... and it continued to spam.

jjones666 · « **Reply #19 on:** February 28, 2007, 08:05:04 am »

Try changing line 210 from:
if($num[0][0] > 0)
To:
if (!empty($num))

This SHOULD fix the string offset crash (PHP5 h8).

I tried the !settings and it works perfectly fine here - please make sure you are using the last Module Settings plugin (2.03) at the following link:

http://bebot.link/index.php/topic,607.0.html

Please let me know outcome and I'll update the plugin after work. I'll also set it to default to spam off for new users.

Cheers,

-jj-

Ozball · « **Reply #20 on:** March 10, 2007, 09:07:25 pm »

Sorry for the late reply.

Also I'm using the lates Settings module. When I put the quotes module back in (took out the _) the spam is set to off(probably left over from last time it was in) and is still spamming..

With the changes to the php file you suggested... I get "[Terminal Velocity] Tvbot: No quotes exist. Add some!" in org chat for the spam. and !quotes works ok (in both tells and gc).

So looks like the only problem atm is the spamming when its set to not spam.